Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved typing of the frontmatter prop. #252

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Improved typing of the frontmatter prop. #252

merged 1 commit into from
Mar 28, 2022

Conversation

MatthijsMud
Copy link
Contributor

Changed the type of the frontmatter prop to better reflect which values it can potentially take on: null, boolean, number, string, Array, or Object (where the latter two recursively allow any of those types).

Closes #249

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 21, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

BRKalow
BRKalow approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@BRKalow BRKalow merged commit 83d821c into hashicorp:main Mar 28, 2022
@reconbot
Copy link

beautiful thank you!

@joemckenney joemckenney mentioned this pull request Apr 27, 2022
Closed
@joemckenney joemckenney mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRKalow BRKalow BRKalow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve typing of the frontmatter prop
4 participants
@MatthijsMud @hashicorp-cla @reconbot @BRKalow