Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loosen frontmatter type and make it configurable #283

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix: loosen frontmatter type and make it configurable #283

merged 1 commit into from
Jul 20, 2022

Conversation

joemckenney
Copy link
Contributor

@joemckenney joemckenney commented Jul 5, 2022 •
edited
Loading

Fix #269 by reverting #252 and making frontmatter's type overrideable through a generic param.

cc @BRKalow

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

BRKalow
BRKalow approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BRKalow BRKalow merged commit 5946145 into hashicorp:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRKalow BRKalow BRKalow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing for frontmatter breaks common usage / misunderstands union types
3 participants
@joemckenney @hashicorp-cla @BRKalow