New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make sure frontmatter types flow through to MDXRemote #351

Merged

BRKalow merged 2 commits into main from brk.fix/frontmatter-types

Mar 1, 2023

Contributor

BRKalow commented Mar 1, 2023

Ensure the tests are type checked
Add statements in tests to validate types are passed through correctly
Update MDXRemote to accept generic types so they flow through correctly from the result of typing serialize()

closes #349


          Address issue with frontmatter types propagating to MDXRemote

8c5b76d

BRKalow requested a review from thiskevinwang

March 1, 2023 15:02


          add test:types script for typechecking, run it

99a21ee

thiskevinwang approved these changes

View reviewed changes

Contributor

thiskevinwang left a comment

Seems good to me!

BRKalow merged commit e4c7a69 into main

BRKalow deleted the brk.fix/frontmatter-types branch

March 1, 2023 19:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment