docs: remove author and url fields from writing packs #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally `app.author` was intended to be the actual author of the app, but many pack maintainers put their own names here. We have the GitHub handles of the actual maintainers, so remove this field from the guide. Likewise, the `pack.url` field doesn't match the actual registry URL if someone forks a registry. Remove that field as well.
tgross
requested review from
angrycub,
DerekStrickland,
jazzyfresh,
jrasell and
lgfa29
as code owners
|
As it turns out, |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally
app.authorwas intended to be the actual author of theapp, but many pack maintainers put their own names here. We have the
GitHub handles of the actual maintainers, so remove this field from
the guide.
Likewise, the
pack.urlfield doesn't match the actual registry URLif someone forks a registry. Remove that field as well.
ref conversation with @mikenomitch in hashicorp/nomad-pack-community-registry#113 (comment) and hashicorp/nomad-pack-community-registry#113 (comment)