Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack: Author field no longer supported in metadata #317

Merged
merged 9 commits into from
May 8, 2023
Merged

pack: Author field no longer supported in metadata #317

merged 9 commits into from
May 8, 2023

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Apr 4, 2023 •
edited
Loading

Description

This PR removes the Author field from pack metadata.

Resolves #300
Relates to #308

Reminders

  • Add CHANGELOG.md entry

angrycub
angrycub approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@angrycub angrycub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to block on that change.

sdk/pack/metadata.go Outdated Show resolved Hide resolved
@pkazmierczak pkazmierczak merged commit befe40b into main May 8, 2023
@pkazmierczak pkazmierczak deleted the f-remove-author branch May 8, 2023 08:17
@pkazmierczak pkazmierczak mentioned this pull request May 23, 2023
Closed
@angrycub angrycub mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angrycub angrycub angrycub approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "author" from pack metadata
2 participants
@pkazmierczak @angrycub