Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass environment variables from host to exec based tasks #970

Merged
merged 2 commits into from
Mar 23, 2016
Merged

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Mar 23, 2016

This PR makes it so raw_exec, exec and java pass environment variables set from the host. There is an operator controllable blacklist specifiable in the client variables as env.blacklist

Fixes #955

@@ -305,6 +306,29 @@ func (t *TaskEnvironment) AppendEnvvars(m map[string]string) *TaskEnvironment {
return t
}

func (t *TaskEnvironment) AppendHostEnvvars(filter []string) *TaskEnvironment {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment

@diptanu
Copy link
Contributor

diptanu commented Mar 23, 2016

LGTM. For Windows platform, will this be sufficient or we need to set more env vars?

@dadgar
Copy link
Contributor Author

dadgar commented Mar 23, 2016

Its sufficient for windows! Example binary provided works!

@dadgar dadgar merged commit 276b7a4 into master Mar 23, 2016
@dadgar dadgar deleted the f-pass-env branch March 23, 2016 21:07
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants