Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify TLS certificate on endpoints that are used between agents only #11956

Merged
merged 9 commits into from
Feb 2, 2022
Merged

Verify TLS certificate on endpoints that are used between agents only #11956

merged 9 commits into from
Feb 2, 2022

Commits on Feb 2, 2022

  1. verify certificate domain on endpoits that are only used for server -… 

    …> server or client -> server communication
    @lgfa29
    lgfa29 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    3320737 View commit details
    Browse the repository at this point in the history

  2. add semgrep rule to check for potentially unauthenticated RPC endpoints

    @lgfa29
    lgfa29 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    fadd3b0 View commit details
    Browse the repository at this point in the history

  3. changelog: add entry for #11956

    @lgfa29
    lgfa29 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    68af15c View commit details
    Browse the repository at this point in the history

  4. move mTLS RPC validation to a helper function

    @lgfa29
    lgfa29 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1904905 View commit details
    Browse the repository at this point in the history

  5. update changelog release note type

    @lgfa29
    lgfa29 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    6ac7d72 View commit details
    Browse the repository at this point in the history

  6. remove dynamic endpoints from staticEndpoints struct

    @lgfa29
    lgfa29 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    8825c2e View commit details
    Browse the repository at this point in the history

  7. remove WARN log line, add context to the returned error

    @lgfa29
    lgfa29 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    a570cd8 View commit details
    Browse the repository at this point in the history

  8. fix wrong RPC endpoint in TestRPC_TLS_Enforcement_RPC

    @lgfa29
    lgfa29 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    c107cc1 View commit details
    Browse the repository at this point in the history

  9. check for nil ctx in *RPCContext.Certificate 

    Endpoints that are re-used are registered without a `ctx` object, so a
call to *RPCContext.Certificate could cause a panic if used in one of
these endpoints.
    @lgfa29
    lgfa29 committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5d540a4 View commit details
    Browse the repository at this point in the history