-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSI: add missing plugin capabilities to api response #12108
Conversation
Detection of the full set of plugin capabilities was added in Nomad 1.1 for the volume creation workflow, but these were not added to the API response for plugins.
11e2cf8
to
4f49ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My one comment would be that some field names are camel cased versions of the full setting name and some are partial. For example, if you had SETTING_NAME sometimes the field is SupportsSettingName
and sometimes it's SupportsSetting
. Not a blocker, but I think it is less ambiguous to use the full setting name, and also helps guard against name collision or prefix reuse upstream that we may not have control over. I realize it's verbose, but that my 2 cents.
I don't disagree and in retrospect I think I probably would have returned a list of these instead of bools anyways. Way-back-when we'd decided we were definitely not going to support create volume, but then came back months later and did it anyways, but by then we had the bool fields and it got pretty gory. 🤣 But in any case, here I'm actually matching the field names from the existing |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Detection of the full set of plugin capabilities was added in Nomad
1.1 for the volume creation workflow, but these were not added to the
API response for plugins.
Blocks showing caps in
plugin status -verbose
#10221Nice-to-have for implementing topology in #7669