tests: minor fixes for some docker tests #13107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
force-pushed
the
b-docker-test-fixes
branch
from
eb73617
to
830b1ff
Compare
shoenig
force-pushed
the
b-docker-test-fixes
branch
from
830b1ff
to
72db527
Compare
shoenig
added
backport/1.2.x
tgross
approved these changes
May 25, 2022
drivers/docker/driver_linux_test.go
Outdated
| defer cleanup() | ||
|
|
||
| driver.WaitUntilStarted(task.ID, time.Duration(tu.TestMultiplier()*5)*time.Second) | ||
|
|
||
| // XXX Logging doesn't work on OSX so just test on Linux |
There was a problem hiding this comment.
While we're here cleaning up, is this comment still relevant?
This was referenced May 25, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fixes #12155 by adding
WaitUntilStartedbefore checking test conditions.Along with some other minor drive-by fixes / improvements in docker tests.