[ui, deployments] Add status panel to child jobs #17217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
changed the title
philrenaud
force-pushed
the
17216-ui-deployments-set-up-steady-state-panel-in-periodicparameterized-jobs
branch
from
282477f
to
d82a8ec
Compare
Ember Asset Size actionAs of 282477f Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
ChaiWithJai
approved these changes
May 16, 2023
Base automatically changed from
17193-ui-deployments-why-arent-child-jobs-watching-allocations
to
main
May 17, 2023 20:36
* In working out periodic/param child jobs, realized the intersection with sysbatch is high enough that it ought to be worked on now * Further removal of jobclientstatussummary * Explicitly making mocked jobs in no-deployment mode * remove last remnants of job-client-status-summary component * Screwed up my sorting order a few commits ago; this corrects it * noActiveDeployment gonna be the death of me
Ember Test Audit comparison
|
philrenaud
deleted the
17216-ui-deployments-set-up-steady-state-panel-in-periodicparameterized-jobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the status panel to periodic/parameterized jobs. In doing so, realized that (since they're batch/sysbatch jobs) we'll want to show "Completed" status before "Failed", since a failed-but-rescheduled-and-eventually-completed alloc should show as Completed, not Failed.
Resolves #17216