-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Adds status panel to Sysbatch jobs #17243
Merged
philrenaud
merged 6 commits into
17216-ui-deployments-set-up-steady-state-panel-in-periodicparameterized-jobs
from
17242-ui-set-up-steady-state-panel-in-sysbatch-jobs
May 19, 2023
Merged
[ui] Adds status panel to Sysbatch jobs #17243
philrenaud
merged 6 commits into
17216-ui-deployments-set-up-steady-state-panel-in-periodicparameterized-jobs
from
17242-ui-set-up-steady-state-panel-in-sysbatch-jobs
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith sysbatch is high enough that it ought to be worked on now
Ember Asset Size actionAs of 74a3c0c Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
philrenaud
changed the title
In working out periodic/param child jobs, realized the intersection w…
[ui] Adds status panel to Sysbatch jobs
May 18, 2023
ChaiWithJai
approved these changes
May 18, 2023
philrenaud
force-pushed
the
17242-ui-set-up-steady-state-panel-in-sysbatch-jobs
branch
from
May 18, 2023 19:11
af3213d
to
d2a0d9d
Compare
philrenaud
merged commit May 19, 2023
445fcf9
into
17216-ui-deployments-set-up-steady-state-panel-in-periodicparameterized-jobs
philrenaud
deleted the
17242-ui-set-up-steady-state-panel-in-sysbatch-jobs
branch
May 19, 2023 19:24
philrenaud
added a commit
that referenced
this pull request
May 19, 2023
* Treated same-route as sub-route and didnt cancel watchers * Adds panel to child jobs and sub-sorts * removed the safety check in module-for-job tests * [ui] Adds status panel to Sysbatch jobs (#17243) * In working out periodic/param child jobs, realized the intersection with sysbatch is high enough that it ought to be worked on now * Further removal of jobclientstatussummary * Explicitly making mocked jobs in no-deployment mode * remove last remnants of job-client-status-summary component * Screwed up my sorting order a few commits ago; this corrects it * noActiveDeployment gonna be the death of me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, removes the
job-status-in-client
panel that was formerly used on system jobs, and more recently only sysbatch jobs. It has since been generally replaced by the new job status panel for steady state.