Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Adds status panel to Sysbatch jobs #17243

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented May 18, 2023

Additionally, removes the job-status-in-client panel that was formerly used on system jobs, and more recently only sysbatch jobs. It has since been generally replaced by the new job status panel for steady state.

…ith sysbatch is high enough that it ought to be worked on now
@philrenaud philrenaud self-assigned this May 18, 2023
@github-actions
Copy link

github-actions bot commented May 18, 2023

Ember Asset Size action

As of 74a3c0c

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -7.17 kB -747 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@philrenaud philrenaud changed the title In working out periodic/param child jobs, realized the intersection w… [ui] Adds status panel to Sysbatch jobs May 18, 2023
@philrenaud philrenaud marked this pull request as ready for review May 18, 2023 18:21
@philrenaud philrenaud merged commit 445fcf9 into 17216-ui-deployments-set-up-steady-state-panel-in-periodicparameterized-jobs May 19, 2023
@philrenaud philrenaud deleted the 17242-ui-set-up-steady-state-panel-in-sysbatch-jobs branch May 19, 2023 19:24
philrenaud added a commit that referenced this pull request May 19, 2023
* Treated same-route as sub-route and didnt cancel watchers

* Adds panel to child jobs and sub-sorts

* removed the safety check in module-for-job tests

* [ui] Adds status panel to Sysbatch jobs (#17243)

* In working out periodic/param child jobs, realized the intersection with sysbatch is high enough that it ought to be worked on now

* Further removal of jobclientstatussummary

* Explicitly making mocked jobs in no-deployment mode

* remove last remnants of job-client-status-summary component

* Screwed up my sorting order a few commits ago; this corrects it

* noActiveDeployment gonna be the death of me
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants