refact: update models for relationship #17315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
lgfa29
approved these changes
May 25, 2023
| module('Unit | Model | NodePool', function (hooks) { | ||
| setupTest(hooks); | ||
|
|
||
| test('a node pool can be associated with multiples nodes', function (assert) { |
There was a problem hiding this comment.
Suggested change
| test('a node pool can be associated with multiples nodes', function (assert) { | |
| test('a node pool can have multiples nodes', function (assert) { |
Minor nit-picking, but I think this describes the expected relationship better.
|
|
||
| assert.equal(nodes.length, 2); | ||
| assert.ok(nodes.includes(node1)); | ||
| assert.ok(nodes.includes(node2)); |
There was a problem hiding this comment.
It may be worth checking that the inverse relationship is also set, so check that node1 and node2 belong to nodePool.
There was a problem hiding this comment.
That's a good call!
philrenaud
approved these changes
May 25, 2023
philrenaud
force-pushed
the
17292/node-pool-ember-data
branch
from
c40f31d
to
df7598c
Compare
* chore: setup mirage models + factory hooks * Acceptance test hardening to avoid faker/mirage randomness --------- Co-authored-by: Phil Renaud <phil@riotindustries.com>
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Jun 21, 2023
* refact: update models for relationship * chore: setup mirage models + factory hooks (#17321) * chore: setup mirage models + factory hooks * Acceptance test hardening to avoid faker/mirage randomness --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> * chore: update comment Co-authored-by: Luiz Aoqui <luiz@hashicorp.com> --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Jun 21, 2023
* refact: update models for relationship * chore: setup mirage models + factory hooks (#17321) * chore: setup mirage models + factory hooks * Acceptance test hardening to avoid faker/mirage randomness --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> * chore: update comment Co-authored-by: Luiz Aoqui <luiz@hashicorp.com> --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Jun 22, 2023
* refact: update models for relationship * chore: setup mirage models + factory hooks (#17321) * chore: setup mirage models + factory hooks * Acceptance test hardening to avoid faker/mirage randomness --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> * chore: update comment Co-authored-by: Luiz Aoqui <luiz@hashicorp.com> --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17293
This PR adds a relationship between the Node and NodePool models. In addition, The Job model now has an @attr('string') property called nodePool.
The nodePool property on the Node model is used to store the name of the NodePool that the job is associated with. The nodes property on the NodePool model is used to store a list of the Job models that are associated with the NodePool.
This change was made to allow users to easily associate jobs with node pools. For example, a user could create a job and specify the name of the node pool that the job should be run on.
Testing
The changes in this PR have been tested using the following tests:
ui/tests/unit/models/node-pool-test.jsThe tests have been written to ensure that the Node and NodePool models can be associated with each other correctly.
Impact
This change will have a minor impact on the codebase. The Node and NodePool models will now have a relationship with each other.
Next Steps
The next steps for this change are to seed the Mirage environments such that
node poolsare reflected. Once that is ready, we'll be ready to visualize the changes in the UI against both a Mirage scenario so that design can sign off and against the real API changes to smoke test the changes.