chore: setup mirage models + factory hooks #17321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaiWithJai
commented
May 25, 2023
There was a problem hiding this comment.
@philrenaud could you pull this down and run the test suite? I'm failing unrelated tests that I believe might have to do with your work, but I'm unsure why that would happen.
philrenaud
approved these changes
May 25, 2023
Ember Test Audit comparison
|
philrenaud
force-pushed
the
17294/mirage-factories
branch
from
a78dc69
to
dd2435c
Compare
philrenaud
force-pushed
the
17294/mirage-factories
branch
from
905b317
to
0aca02e
Compare
ChaiWithJai
added a commit
that referenced
this pull request
May 31, 2023
* refact: update models for relationship * chore: setup mirage models + factory hooks (#17321) * chore: setup mirage models + factory hooks * Acceptance test hardening to avoid faker/mirage randomness --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> * chore: update comment Co-authored-by: Luiz Aoqui <luiz@hashicorp.com> --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Jun 21, 2023
* refact: update models for relationship * chore: setup mirage models + factory hooks (#17321) * chore: setup mirage models + factory hooks * Acceptance test hardening to avoid faker/mirage randomness --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> * chore: update comment Co-authored-by: Luiz Aoqui <luiz@hashicorp.com> --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Jun 21, 2023
* refact: update models for relationship * chore: setup mirage models + factory hooks (#17321) * chore: setup mirage models + factory hooks * Acceptance test hardening to avoid faker/mirage randomness --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> * chore: update comment Co-authored-by: Luiz Aoqui <luiz@hashicorp.com> --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Jun 22, 2023
* refact: update models for relationship * chore: setup mirage models + factory hooks (#17321) * chore: setup mirage models + factory hooks * Acceptance test hardening to avoid faker/mirage randomness --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> * chore: update comment Co-authored-by: Luiz Aoqui <luiz@hashicorp.com> --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17294
This PR adds a new
node-poolMirage model and updates thenodeMirage model that has anode-poolrelationship. It also updates the factories fornodeto create an associatednode-pooland thejobfactory to associate itself to anode-pool.Impact
This PR impacts our Mirage server and the fake calls we make.
Side Effect
This PR runs prettier on
mirage/factories/nodeso just pay attention to theafterCreatehook changes.Next Steps
This is the final prerequisite we need to start developing against the real API. We'll start PRs that impact the view layer next.