release pipeline: fix ref arguments in invoking workflow #17684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although #17669 fixed the permissions of the release pipeline to push new commits, there was still an error when invoking the `build` workflow. The format of the reference was changed in #17103 such that we're sending the git ref (a SHA) and not the "--ref" argument required by the GH actions workflow API, which in this case is apparently specially defined as "The branch or tag name which contains the version of the workflow file you'd like to run" and not what git calls a "ref". This changeset: * Removes the third-party action entirely so that we're using GitHub's own tooling. This removes one more thing from the supply chain to pin and ensures a 1:1 mapping of args to what's documented by GitHub. * Removes the `--ref` argument entirely, which causes it to default to the current branch that the release workflow is running on (which is always what we want).
tgross
added
theme/build-infrastructure
backport/1.3.x
lgfa29
approved these changes
Jun 22, 2023
shore
approved these changes
Jun 22, 2023
This was referenced Jun 22, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although #17669 fixed the permissions of the release pipeline to push new commits, there was still an error when invoking the
buildworkflow.The format of the reference was changed in #17103 such that we're sending the git ref (a SHA) and not the "--ref" argument required by the GH actions workflow API, which in this case is apparently specially defined as "The branch or tag name which contains the version of the workflow file you'd like to run" and not what git calls a "ref".
This changeset:
--refargument entirely, which causes it to default to the current branch that the release workflow is running on (which is always what we want).Tested out in https://github.com/hashicorp/nomad-enterprise/actions/runs/5349266786 (after many many iterations 😀 )