Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Lockfile and bindata_assetfs recompiled on latest main #22434

Merged
merged 1 commit into from
May 31, 2024
Merged

[ui] Lockfile and bindata_assetfs recompiled on latest main #22434

merged 1 commit into from
May 31, 2024

Conversation

philrenaud
Copy link
Contributor

Recently, we've made a few changes that affected our JS dependencies heavily (such as the removal of storybook and Helios/PowerSelect upgrades)

On the back of these changes, it seemed worthwhile to update our UI lockfile and run a fresh make dev-ui and commit the generated assets.

@philrenaud philrenaud self-assigned this May 31, 2024
gulducat
gulducat approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Ember Test Audit comparison

main af56168 change
passes 1572 1572 0
failures 0 0 0
flaky 0 0 0
duration 11m 24s 144ms 11m 25s 029ms +885ms

@philrenaud philrenaud force-pushed the b-ui/1.8.x-ui-asset-recompile branch from f72454b to af56168 Compare May 31, 2024 16:40
@philrenaud philrenaud added the backport/1.8.x backport to 1.8.x release line label May 31, 2024
@philrenaud philrenaud merged commit 014f514 into main May 31, 2024
32 checks passed
@philrenaud philrenaud deleted the b-ui/1.8.x-ui-asset-recompile branch May 31, 2024 17:24
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request May 31, 2024
Merged
philrenaud added a commit that referenced this pull request May 31, 2024
@philrenaud
Lockfile and bindata_assetfs recompiled on latest main (#22434)
f75b8e5
philrenaud added a commit that referenced this pull request May 31, 2024
@philrenaud
Lockfile and bindata_assetfs recompiled on latest main (#22434)
f36eb52
philrenaud added a commit that referenced this pull request May 31, 2024
@hc-github-team-nomad-core @philrenaud
Backport of [ui] Lockfile and bindata_assetfs recompiled on latest ma…
77ddcf7 
…in into release/1.8.x (#22436)

* no-op commit due to failed cherry-picking

* Lockfile and bindata_assetfs recompiled on latest main (#22434)

---------

Co-authored-by: temp <temp@hashicorp.com>
Co-authored-by: Phil Renaud <phil.renaud@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gulducat gulducat gulducat approved these changes

@angrycub angrycub Awaiting requested review from angrycub

Assignees

@philrenaud philrenaud

Labels
backport/1.8.x backport to 1.8.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philrenaud @gulducat