[ui] Helios and Power Select upgrades #22328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
philrenaud
commented
May 24, 2024
philrenaud
commented
- Upgrading Helios to 4.3.0
- ember-element-helper was previously pinned because of an old version of ember-power-select, which is now also upgraded, so pin removed.
Ember Test Audit comparison
|
philrenaud
commented
May 24, 2024
| @@ -106,7 +106,7 @@ | |||
| "ember-on-resize-modifier": "^1.0.0", | |||
| "ember-overridable-computed": "^1.0.0", | |||
| "ember-page-title": "^7.0.0", | |||
| "ember-power-select": "^4.1.7", | |||
| "ember-power-select": "^7.2.0", | |||
There was a problem hiding this comment.
Note: I could upgrade this to v8+, but that requires adding extra template code per https://ember-power-select.com/docs/migrate-7-0-to-8-0 and I think my time would be better suited moving away from ember-power-select raw usage generally (we use it for our global search, among other things). Helios' dropdown component will be a more than sufficient replacement for it.
alex-ju
approved these changes
May 28, 2024
philrenaud
force-pushed
the
helios-4.3.0-upgrade
branch
from
980f46d
to
2e3e6a4
Compare
philrenaud
added a commit
that referenced
this pull request
May 31, 2024
* Helios and Power Select upgrades * Renamed namespaced contextual components
philrenaud
added a commit
that referenced
this pull request
May 31, 2024
* Helios and Power Select upgrades * Renamed namespaced contextual components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.