Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add bugfix notes for #7690 #7397 #7684 #7683 to changelog #7691

Merged
merged 1 commit into from Apr 20, 2020

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Apr 10, 2020

No description provided.

@shoenig shoenig requested a review from notnoop April 11, 2020 00:02
@shoenig
Copy link
Member Author

shoenig commented Apr 11, 2020

Pending #7690

CHANGELOG.md Outdated
Comment on lines 6 to 8
* connect: Fixed a bug where some configured fields for connect proxy would be ignored [[GH-7690](https://github.com/hashicorp/nomad/pull/7690)]
* connect: Fixed a bug where some connect proxy fields would be dropped from 'job inspect' output [[GH-7397](https://github.com/hashicorp/nomad/issues/7397)]
* connect: Fixed a bug where a configured connect sidecar task name would be ignored [[GH-7684](https://github.com/hashicorp/nomad/pull/7684)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the details useful to users? or can we get away with a bit more generic ".. where some connect fields are ignored" category and we can link to the PRs.

@shoenig shoenig merged commit 0017601 into master Apr 20, 2020
@shoenig shoenig deleted the docs-some-connect-bugs branch April 20, 2020 16:27
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants