Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the parent's Subscription when checking for Specialized SIG #322

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

JenGoldstrich
Copy link
Contributor

In v1.4.4 of the plugin a regression was shipped (#321) where when checking if a source SIG image is specialized or not we were passing in the build's subscription, because of this if you built a SIG image based on a SIG image in another subscription in v1.4.4 you receive the following error

==> azure-arm.linux-sig: Running builder ...
==> azure-arm.linux-sig: Getting tokens using Azure CLI
==> azure-arm.linux-sig: Getting tokens using Azure CLI
    azure-arm.linux-sig: Creating Azure Resource Manager (ARM) client ...
Build 'azure-arm.linux-sig' errored after 1 second 97 milliseconds: the parent Shared Gallery Image 'acctestgallery' from which to source the managed image version to does not exist in the resource group 'jenna-other-sub' or does not contain managed image 'arm-linux-specialized-sig'

==> Wait completed after 1 second 97 milliseconds

==> Some builds didn't complete successfully and had errors:
--> azure-arm.linux-sig: the parent Shared Gallery Image 'acctestgallery' from which to source the managed image version to does not exist in the resource group 'jenna-other-sub' or does not contain managed image 'arm-linux-specialized-sig'

==> Builds finished but no artifacts were created.

After this change trying to build the same image is successful.

Closes #321

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JenGoldstrich JenGoldstrich merged commit 52a4f88 into main Jul 19, 2023
11 checks passed
@JenGoldstrich JenGoldstrich deleted the fix_sig_parent_wrong_subscription branch July 19, 2023 20:10
@shyoon-devops
Copy link

Cool!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find shared_image_gallery
3 participants