Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fusion 13 x86_x64 vmware tools location #139

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

coffeegist
Copy link
Contributor

@coffeegist coffeegist commented Jun 6, 2023

This is a hotfix to amend a previous PR supporting VMWare Fusion 13 and it's updated VMTools paths (#112)

Closes #137

@coffeegist coffeegist requested a review from a team as a code owner June 6, 2023 16:46
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 6, 2023

CLA assistant check
All committers have signed the CLA.

@coffeegist
Copy link
Contributor Author

I was beat to it :) #138 can handle this, and this one can be closed

@tenthirtyam
Copy link
Collaborator

Superceeds #138.

@tenthirtyam tenthirtyam changed the title * Update vmtools path for VMWare Fusion 13 fix: fusion 13 x86_x64 vmware tools location Aug 22, 2023
@tenthirtyam tenthirtyam self-requested a review August 22, 2023 00:59
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Superceeds #138.

@tenthirtyam
Copy link
Collaborator

Reference: #138 (comment)

Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review here folks, and thank you for pushing keeping the ball rolling. This looks good to me as well.

@nywilken nywilken merged commit 4358ab5 into hashicorp:main Aug 22, 2023
12 checks passed
@Stromweld
Copy link
Contributor

@nywilken is there going to be a release soon with this bug fix in it?

@nywilken
Copy link
Member

@Stromweld I will trigger a release now, actually.

@Stromweld
Copy link
Contributor

thanks

@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vmware-iso: "Couldn't find VMware tools for 'linux'!"
5 participants