fix: vmware tools iso path for Fusion 13

[Stromweld]

VMware Fusion 13.x.x moved the tools iso files based on cpu arch.

Closes #109

[hashicorp-cla]

All committers have signed the CLA.

[Stromweld]

I'm new to golang as in this is the first time i've tried doing anything in golang so may need a bit of help if this is not correct.

[lbajolet-hashicorp]

Hi @Stromweld,

There are some compilation errors in the code, which should get resolved by adding the missing import statement.

Other than that, I left some suggestions for the code, feel free to take a look and don't hesitate to reach out if you need help on implementing the feature.

That being said, thanks for taking a jab at this problem, looking forward to helping you getting this in.

[Stromweld]

@lbajolet-hashicorp I fixed the missing runtime import, I'm not sure what I'd need to find the Guest OS type to fix the outer if statement.

[nywilken]

👋 I'm waiting on version of Fusion 13 to test. I have a nit suggestion and a question about the the Windows conditional.

[Stromweld]

@lbajolet-hashicorp any other updates you'd like to see on this?

[nywilken]

Overall this looks good. I would like to merge but I’m having trouble testing it. @Stromweld can you confirm that the modified code works as expected for your test environment , please.

[Stromweld]

@nywilken I'm having trouble with that. I swapped my m1 mac mini for a new m2 mac mini. I can't seem to get packer vmware-iso builds to provision at all. See https://github.com/chef/bento/actions/runs/4328485365/jobs/7558243945. I'm using a hard coded path that fixed the error in the plugin and was allowing the builds to run on my previous m1 mac mini. Not sure if a packer update, vmware-fusion update, or the m2 upgrade is the culprit, as all has happened while waiting to get my M2. PACKER_LOG=1 doesn't give me any additional information. I'm running the latest versions of each software. It'll take me a bit to test different versions of software to see if I can get it working again.

[nywilken]

@nywilken I'm having trouble with that. I swapped my m1 mac mini for a new m2 mac mini. I can't seem to get packer vmware-iso builds to provision at all. See https://github.com/chef/bento/actions/runs/4328485365/jobs/7558243945. I'm using a hard coded path that fixed the error in the plugin and was allowing the builds to run on my previous m1 mac mini. Not sure if a packer update, vmware-fusion update, or the m2 upgrade is the culprit, as all has happened while waiting to get my M2. PACKER_LOG=1 doesn't give me any additional information. I'm running the latest versions of each software. It'll take me a bit to test different versions of software to see if I can get it working again.

Thanks for giving this a test run. I’m running into the same error.

I spent some time looking into it and found that the guest type needs to be set to arm-denian-64 to get the iso to take. But fusion runs into a boot issue because the scsi disk type is no longer supported. Guessing we might need to create a new driver that creates a valid vmx file for fusion 13.

[Stromweld]

@nywilken So I got my templates working again by switching vmware_cdrom_adapter_type to "sata", vmware_disk_adaptor_type to "sata", and setting my ubuntu templates with vmware_guest_os_type to "arm-ubuntu-64". That got me past the service implementation error. Now how do I figure out all the guest OS types for vmware arm machines. Or is it as simple as the same as x86_64 but with "arm-" prefix now?

[nywilken]

@Stromweld thanks for updating the PR with your latest changes. I pulled down your repo to work with it as well. I see the changes are working. I think this is in a good place to merge. But we will need to update the documentation for Fusion 13 as the adapter_types and guest_os_types changes won't be so obvious. This is a change for me tomorrow.

[nywilken]

The changes look good and have been validated to work.

The changes have been applied and the plugin works as expected.

[Stromweld]

Thanks for the update

[nywilken]

Thanks for the update

@Stromweld maybe you can help me out. I reinstalled Fusion 13.0.1 and I am finding that my builds (M1 pro) freeze at the grub menu. I'm using the bento packer templates. Did you run into this issue?

If so is there something outside of Packer that I need to do to get things working?

[Stromweld]

@nywilken Sorry just saw this now, I did run into the same issue and found from another user some config changes that are needed for arm builds to work. I've incorporated those into recent bento packer templates. There is still a lot more work that needs to be done on the arm variables/templates that I haven't gotten around to. Several machines are building on arm now for both parallels and vmware. My focus is getting the x86_64 builds all working correctly for parallels, virtualbox, and vmware, then focusing on arm, and then hyper-v and qemu. Doing this as side work so it's slow going.