Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Oracle plugin from the list of vendored plugins #11983

Merged
merged 1 commit into from Sep 15, 2022
Merged

Remove Oracle plugin from the list of vendored plugins #11983

merged 1 commit into from Sep 15, 2022

Conversation

nywilken
Copy link
Member

@nywilken nywilken commented Sep 14, 2022 •
edited

The latest release of the Oracle plugin for Packer removed Solaris from its list of supported platforms. Since Packer still
releases binaries for Solaris. So the Oracle plugin will no longer be bundled and distributed within the Packer binary. Practitioners relying on the plugin can continue using the plugin by installing it manually using either the packer init or packer plugins install commands.

Related to: hashicorp/packer-plugin-oracle#58

@nywilken
Remove Oracle plugin from the list of vendored plugins
9cf71e6 
The latest release of the Oracle plugin for Packer removed
Solaris from its list of supported platforms. Since Packer still
releases binaries for Solaris the Oracle plugin will no longer be
bundled and distributed within the Packer binary. Practitioners relying
on the plugin can continue using the plugin by installing it manually
using either the `packer init` or `packer plugins install` commands.
@nywilken nywilken requested a review from a team as a code owner September 14, 2022 00:42
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this means that the oracle plugin now needs to be either manually installed or through packer init with a required_plugin block in the packer section?
If so, I guess this should be explicitly mentioned in the release notes when we do release a new version of Packer so clients are aware of the potential incompatibility.

Other than that, LGTM

@nywilken
Copy link
Member Author

I imagine this means that the oracle plugin now needs to be either manually installed or through packer init with a required_plugin block in the packer section? If so, I guess this should be explicitly mentioned in the release notes when we do release a new version of Packer so clients are aware of the potential incompatibility.

Other than that, LGTM

You are 100% correct. I plan to add the PR description to the notes section within the CHANGELOG. Does the summary capture your concern?

@nywilken nywilken merged commit 11e7172 into main Sep 15, 2022
@nywilken nywilken deleted the nywilken/unbundle_packer-plugin-oracle branch September 15, 2022 16:31
@nywilken nywilken added this to the 1.8.4 milestone Oct 14, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Assignees
No one assigned
Labels
core-plugin-split
Projects
None yet
Milestone
1.8.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nywilken @lbajolet-hashicorp