Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sftp file transfer support #2504

Merged
merged 1 commit into from
Feb 3, 2016
Merged

Conversation

2opremio
Copy link

Adds a new config option: "ssh_file_transfer_method", which can be set to "scp"
or "sftp" (defaults to "scp")

Quoting @mitchellh in #1991: "If I saw an SFTP PR though, I'd be happy to merge it." Well, here it is :)

Adds a new config option: "ssh_file_transfer_method", which can be set to "scp"
or "sftp" (defaults to "scp")
@cbednarski
Copy link
Contributor

Thanks this looks great -- docs, tests, and all! I have not had a chance to review this in detail so I can't promise this will make it into 0.8.3 but I will get to this soonish.

@cbednarski cbednarski added this to the future milestone Jul 31, 2015
@2opremio
Copy link
Author

2opremio commented Aug 3, 2015

@cbednarski You're welcome. Let me know if there's anything I can do to get this through.

@cbednarski cbednarski modified the milestones: v0.9.0, upcoming Aug 21, 2015
@2opremio
Copy link
Author

Hi @cbednarski . Without meaning to push you, do you have an estimation of when you will be able to merge this? This PR has been here for almost two months now.

@2opremio
Copy link
Author

@cbednarski ping

@2opremio
Copy link
Author

@cbednarski 6 months and counting, I think this one's going to reach a record :)

@cbednarski cbednarski merged commit a59c82d into hashicorp:master Feb 3, 2016
@cbednarski
Copy link
Contributor

Sorry to keep you waiting so long on this. The PR looks great! I merged this locally to resolve conflicts.

6 months and counting, I think this one's going to reach a record :)

(Un)fortunately I don't think we managed to set a record on this one.

Thanks for contributing to packer!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants