Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to detect the guest IP address with Get-NetNeighbor #5993

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 39 additions & 4 deletions common/powershell/hyperv/hyperv.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,55 @@ return $false
return cmdOut, err
}

func GetVirtualMachineNetworkAdapterMacAddress(vmName string) (string, error) {

var script = `
param([string]vmName)
try {
$adapter = Hyper-V\Get-VMNetworkAdapter -VMName $vmName -ErrorAction SilentlyContinue
$macaddr = $adapter.MacAddress -replace "(\w{2})(\w{2})(\w{2})(\w{2})(\w{2})(\w{2})", '$1-$2-$3-$4-$5-$6'
if ($macaddr -eq null) {
return $false
}
} catch {
return $false
}
$macaddr
`
var ps powershell.PowerShellCmd
cmdOut, err := ps.Output(script, vmName)

return cmdOut, err
}

func GetVirtualMachineNetworkAdapterAddress(vmName string) (string, error) {

var script = `
param([string]$vmName, [int]$addressIndex)
param([string]$vmName, [int]$addressIndex, [string]$macaddress)
try {
$adapter = Hyper-V\Get-VMNetworkAdapter -VMName $vmName -ErrorAction SilentlyContinue
$ip = $adapter.IPAddresses[$addressIndex]
if($ip -eq $null) {
return $false
$ip = (Get-NetNeighbor -LinkLayerAddress $macaddress).IPAddress
if ($ip -eq $null) {
return $false
}
}
} catch {
return $false
}
$ip
`
cmdOut, err := GetVirtualMachineNetworkAdapterMacAddress(vmName)

var macaddress string
macaddress = strings.TrimSpace(cmdOut)
if macaddress == "False" {
macaddress = ""
}

var ps powershell.PowerShellCmd
cmdOut, err := ps.Output(script, vmName, "0")
cmdOut, err = ps.Output(script, vmName, "0", macaddress)

return cmdOut, err
}
Expand Down Expand Up @@ -983,7 +1014,11 @@ try {
$ip = Hyper-V\Get-Vm | %{$_.NetworkAdapters} | ?{$_.MacAddress -eq $mac} | %{$_.IpAddresses[$addressIndex]}

if($ip -eq $null) {
return ""
$macaddr = $mac -replace "(\w{2})(\w{2})(\w{2})(\w{2})(\w{2})(\w{2})", '$1-$2-$3-$4-$5-$6'
$ip = (Get-NetNeighbor -LinkLayerAddress $macaddr).IPAddress
if ($ip -eq $null) {
return ""
}
}
} catch {
return ""
Expand Down