Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tar header format to tar.FormatGNU #6084

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Set tar header format to tar.FormatGNU #6084

merged 1 commit into from
Mar 29, 2018

Conversation

StefanScherer
Copy link
Contributor

With Golang 1.10 a problem with macOS tar (bsdtar using libarchive) occured listing huge files as zero byte files. After some investigation in golang/go#24599 we got some work around to set the tar header format explicitly to FormatGNU. Such tar files can be read and extracted with macOS tar.

Closes #5990

@StefanScherer StefanScherer requested a review from a team as a code owner March 29, 2018 20:50
@mwhooker mwhooker added this to the v1.2.3 milestone Mar 29, 2018
@dsnet
Copy link

dsnet commented Mar 29, 2018

FYI, doing this will cause the minimal version of Go to be Go1.10 since tar.Header.Format was only added in that version. The alternative is to place this behind a build tag.

@mwhooker
Copy link
Contributor

thanks again for all the investigatory work and for this patch!

@mwhooker mwhooker merged commit 71dcc0f into hashicorp:master Mar 29, 2018
@StefanScherer StefanScherer deleted the set-tar-header-format-gnu branch March 29, 2018 20:55
@StefanScherer
Copy link
Contributor Author

Thanks @dsnet for your quick help.
That's why Travis errors out in the matrix build.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packer produces 0 byte vmdk
3 participants