fix attaching keypair error due to missing keypair name

[chhaj5236]

KeyPair is created in stepConfigAlicloudKeyPair and stored in Comm field, but stepAttachKeyPair uses config.Comm.SSHKeyPairName which is found out to be an empty string. This causes stepAttachKeyPair#Run returns immediately without actually attaching the KeyPair.

This fix passes Comm field to stepAttachKeyPair to make use of the KeyPair generated.

[azr]

Hello, thanks for the PR 🙂 , the actual problem here is that config is stored as a copy in the state bag.
config.Comm.SSHKeyPairName is updated during build steps; but since it's stored as a copy in the state bag it won't be updated.

So a nicer fix here would to change the state.Get("config").(Config) calls to be state.Get("config").(*Config) and

packer/builder/alicloud/ecs/builder.go

Line 78 in fadfb69

state.Put("config", b.config)

to state.Put("config", &b.config) too.

Thanks 🙂

[azr]

This config should be a pointer so that you don't have to add a field to stepAttachKeyPair .

config := state.Get("config").(*Config)

[chhaj5236]

@azr I have done the change. That was a great suggestion and it did fix the issue.

[azr]

Awesome, thanks people 🙂

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.