add ability to define multiple NICs for vsphere-iso

[jhawk28]

Added the ability to define multiple network adapters and their respective parameters for the vsphere-iso builder. Network and network_card parameters are still there for backwards compatibility (will be used as the first network adapter if defined). Added the ability to manually define a mac address for the NIC and also enable/disable the directpath i/o.

Closes #8719
Closes #8618

[azr]

Super nice one, LGTM, thanks for the contrib.

This is a config breaking change and I think we will need to wait for a minor release (1.6.0) to be planned to merge this.

[jhawk28]

It still accepts the old configs. I did not remove any parameters (network+networkCard). network_adapters was added. Should not be a breaking change.

[azr]

Network,NetworkCard are nested into an array, so yes they are still there but the users who already have a conf with an unnested networkCard and or network will need to fix their config file. BTW I think we also need to add a fixer to this, you can find examples in the fix/ folder.

[jhawk28]

The original network and network_card fields are still there (step_create:45-48). You can see how I generate a NIC struct with them on step_connect:102. If we want to go the fix route, then I can remove the fields and add a "fix".

[azr]

Oh right, I'm sorry I though they were removed because of this change: https://github.com/hashicorp/packer/pull/8739/files#diff-57d6257e1da6868d360bd78403640dd9L59-L60

[jhawk28]

No problem. The vpshere-iso configuration vs driver data split is a little weird. I'll do a second pull request for removing the old fields and adding the "fix" to clean things up for 1.6.0.

[azr]

Superawesome; thanks @jhawk28 🙂

[sylviamoss]

It looks good to me! Let's just get another approval and we can merge this one 👍

[sylviamoss]

Ops, already have two approvals 😄 Nice!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.