Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestRaft_StartAsLeader #386

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix TestRaft_StartAsLeader #386

merged 1 commit into from
Feb 6, 2020

Conversation

schristoff
Copy link
Contributor

TestRaft_StartAsLeader and TestRaft_SingleNode are similar however a key difference is StartAsLeader uses the "StartAsLeader" configuration flag which through testing we are finding is causing multiple failures.
We will continue to dig in to see if this configuration flag is necessary, and if not we can "fix" this test by removing the flag.

@schristoff
Copy link
Contributor Author

Relevant Issue: #372
The backstory behind the flag is that we wanted nodes to not "elect" themselves as leaders but just start as a leader so that starting up a -dev mode type of cluster or running tests could be faster.

Copy link

@langmartin langmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Since StartAsLeader was part of our public interface and at least one downstream project used it, should we leave it in the config file and have it log a warning instead of doing anything?

Copy link

@langmartin langmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking and talking about it: I think this is fine, and we should just add a line in the Changelog to document removing the config field

@schristoff schristoff merged commit a11d1bd into master Feb 6, 2020
@schristoff schristoff deleted the Fix-StartAsLeader branch February 6, 2020 16:18
stapelberg added a commit to robustirc/robustirc that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants