futures can react to shutdown #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnoop
reviewed
Feb 27, 2020
| @@ -146,6 +146,7 @@ func (r *Raft) takeSnapshot() (string, error) { | |||
| // We have to use the future here to safely get this information since | |||
| // it is owned by the main thread. | |||
| configReq := &configurationsFuture{} | |||
| configReq.ShutdownCh = r.shutdownCh | |||
There was a problem hiding this comment.
It may be nice to document when ShutdownCh needs to be set and what makes snapshotting special. I assume it's because snapshotting runs in an internal gorotouine and can run regardless of leadership. Other futures will be responded to immediately when not leader, or when raft loses leadership as a result of shutting down?
| err error | ||
| errCh chan error | ||
| responded bool | ||
| ShutdownCh chan struct{} |
There was a problem hiding this comment.
very nit picky - can this field be private like the rest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementing a very similar thing to #277 but a little bit more generalized, like suggested by @mkeeler.
Fixes #277, fixes #268.