Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-page): make certain docs-page types optional #362

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

BRKalow
Copy link
Contributor

@BRKalow BRKalow commented Sep 29, 2021

🎟️ Asana Task
πŸ” Preview Link


Description

showEditPage, showVersionSelect, and additionalComponents are not necessary to be specified for every usage, making them optional!

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@BRKalow BRKalow requested a review from a team September 29, 2021 15:54
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2021

πŸ¦‹ Changeset detected

Latest commit: 6bf598f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-docs-page Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/BRV9yYCY5AFoWcXRenqyAzjMcG9X
βœ… Preview: https://react-components-git-brkfix-docs-page-types-hashicorp.vercel.app

Copy link
Contributor

@thiskevinwang thiskevinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@BRKalow BRKalow changed the title make certain docs-page types optional fix(docs-page): make certain docs-page types optional Sep 29, 2021
@BRKalow BRKalow merged commit 77e5712 into main Sep 29, 2021
@BRKalow BRKalow deleted the brk.fix/docs-page-types branch September 29, 2021 16:07
@github-actions github-actions bot mentioned this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants