Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-page): process.env.ENABLE_VERSIONED_DOCS is string #382

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

thiskevinwang
Copy link
Contributor

@thiskevinwang thiskevinwang commented Oct 4, 2021

🎟️ -
πŸ” -


Description

This updates logic to treat process.env.ENABLE_VERSIONED_DOCS as string

  • environment variables are always strings.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

- `process.env.ENABLE_VERSIONED_DOCS === 'true'`
@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2021

πŸ¦‹ Changeset detected

Latest commit: bd3010a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-docs-page Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/2TUteFP4bdtZZn1CjHrU8KpyG73Q
βœ… Preview: https://react-components-git-kevin-env-vars-always-strings-hashicorp.vercel.app

@thiskevinwang thiskevinwang changed the title Kevin/env-vars-always-strings fix(docs-page): process.env.ENABLE_VERSIONED_DOCS is string Oct 4, 2021
@thiskevinwang thiskevinwang requested a review from a team October 4, 2021 23:08
@thiskevinwang thiskevinwang merged commit cc46ed6 into main Oct 5, 2021
@thiskevinwang thiskevinwang deleted the kevin/env-vars-always-strings branch October 5, 2021 17:54
@github-actions github-actions bot mentioned this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants