-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs-page): support passing remarkPlugins as a fn #524
Conversation
π¦ Changeset detectedLatest commit: 55a2ec4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). π Inspect: https://vercel.com/hashicorp/react-components/4Dcpp16vBcViuRrYVRDu3aeKUkby |
π¦ Canary Packages PublishedLatest commit: 0326a5b Published 1 packages@hashicorp/react-docs-page@14.15.0-canary-20220324182850
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the same support for the FS loader, which is what terraform-website
will need for terraform-cdk
local previw
if (!Array.isArray(remarkPlugins)) { | ||
throw new Error( | ||
'`remarkPlugins:` When specified as a function, must return an array of remark plugins' | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice π
ποΈ Asana Task
π Preview Link
Description
This updates both the
Remote
andFileSystem
data loaders to accept a function forremarkPlugins
. The function is called with the current pages paramsPR Checklist π
Items in this checklist may not may not apply to your PR, but please consider each item carefully.