fix(docs-page): TFE version stripping #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b3e105a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thiskevinwang
added
the
release:canary
thiskevinwang
commented
Jul 6, 2022
| }) | ||
|
|
||
| it('should strip a TFE version string', () => { | ||
| const [version, params] = stripVersionFromPathParams([ | ||
| 'enterprise', |
There was a problem hiding this comment.
I removed this because it was an inaccurate input.
Given
/enterprise/[[...page]].tsx
Then
enterprisewill never be first in thectx.params.pagelist, unless the path is/enterprise/enterprise
📦 Canary Packages PublishedLatest commit: b3e105a Published 1 packages@hashicorp/react-docs-page@17.1.2-canary-20220706153646 |
thiskevinwang
changed the title
|
Testing via hashicorp/terraform-website#2370 |
|
Going to merge this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Asana Task
🔍 Preview Link
Description
This fixes a case where a TFE version that is expected to be in the URL was being accidentally removed.
PR Checklist 🚀
Items in this checklist may not may not apply to your PR, but please consider each item carefully.