feat: refactor version-alert text #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: b604737 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thiskevinwang
commented
Aug 2, 2022
| @@ -5,25 +5,24 @@ import { | |||
| removeVersionFromPath, | |||
| } from '../version-select/util' | |||
| import s from './style.module.css' | |||
There was a problem hiding this comment.
This cuts down some logic in this component, and makes it closer to a purely presentational component
thiskevinwang
commented
Aug 2, 2022
|
|
||
| expect(getByTestId('tag')).toHaveTextContent('old version') | ||
| expect(getByTestId('text')).toHaveTextContent('Some Text') | ||
| }) |
There was a problem hiding this comment.
Cleaned up tests due to slimmed down logic
There was a problem hiding this comment.
There is only one thing to test for now — if versionInPath is present, or not.
thiskevinwang
added
the
release:canary
BRKalow
approved these changes
Aug 2, 2022
📦 Canary Packages PublishedLatest commit: 2077a09 Published 1 packages@hashicorp/react-docs-page@17.3.2-canary-20220802201454 |
Co-authored-by: Bryce Kalow <bkalow@hashicorp.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the version-alert to use the
displayvalue that is returned from the ContentAPI