Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove @reach/auto-id #938

Merged
merged 1 commit into from Apr 25, 2023
Merged

feat: remove @reach/auto-id #938

merged 1 commit into from Apr 25, 2023

Conversation

dstaley
Copy link
Contributor

@dstaley dstaley commented Apr 19, 2023

🎟️ Asana Task
πŸ” Preview Link


Description

This PR removes @reach/auto-id in favor of React.useId in react-form-fields. The remaining packages using @reach/auto-id are no longer being maintained.

As a part of this PR, @types/react was updated to v18, and react-docs-page was adjusted to account for the breaking changes (namely the deprecation of the FunctionalComponent utility type).

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@dstaley dstaley requested a review from BRKalow April 19, 2023 21:38
@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

πŸ¦‹ Changeset detected

Latest commit: 68f9013

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hashicorp/react-form-fields Minor
@hashicorp/react-docs-page Minor
@hashicorp/react-marketo-form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview Apr 19, 2023 9:38pm

@thiskevinwang thiskevinwang self-requested a review April 20, 2023 22:12
Copy link
Contributor

@thiskevinwang thiskevinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🀾 - - - - - πŸͺ¨ 🐦 🐦

Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ™

@dstaley dstaley merged commit b4ac21a into main Apr 25, 2023
7 checks passed
@dstaley dstaley deleted the ds.remove-autoid branch April 25, 2023 17:26
@hashibot-web hashibot-web mentioned this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants