Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ConsentManager): Enable onLoad functionality for scripts #981

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

nandereck
Copy link
Contributor

@nandereck nandereck commented Jul 11, 2023

🎟️ Asana Task
πŸ” Preview Link

Description

This change enables onLoad functionality for scripts loaded via the ConsentManager component. This will allow us to register an event handler to track events for the Qualified chatbot.

Validation Steps

Screenshot 2023-07-12 at 9 33 53 AM

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

πŸ¦‹ Changeset detected

Latest commit: 0ea681b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-consent-manager Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 11, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 11, 2023 9:07pm

@nandereck nandereck added the release:canary Triggers a canary release for commits to this pull request label Jul 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

πŸ“¦ Canary Packages Published

Latest commit: 0ea681b

Published 1 packages

@hashicorp/react-consent-manager@9.2.0-canary-20230711210816

npm install @hashicorp/react-consent-manager@canary

@nandereck nandereck requested review from a team and EnMod and removed request for a team July 12, 2023 16:34
Copy link
Contributor

@EnMod EnMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified no errors in Swingset, and the script loads in the DOM in the www preview. LGTM!

@nandereck nandereck merged commit 0aedf44 into main Jul 14, 2023
5 checks passed
@nandereck nandereck deleted the nels/update-consent-manager branch July 14, 2023 14:38
@hashibot-web hashibot-web mentioned this pull request Jul 14, 2023
nandereck pushed a commit that referenced this pull request Jul 14, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

# Releases
## @hashicorp/react-consent-manager@9.2.0

### Minor Changes

-   [#981](#981) [`0aedf445`](0aedf44) Thanks [@nandereck](https://github.com/nandereck)! - Add onload functionality to scripts handled by ConsentManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants