Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update action runner to use NodeJS 20 #90

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

ahanoff
Copy link
Contributor

@ahanoff ahanoff commented Jan 30, 2024

Close #89

Note

https://github.blog/changelog/2022-05-20-actions-can-now-run-in-a-node-js-16-runtime/ As a result, actions authors who move from targeting Node.js 12 to Node.js 16 should release with a new major version number to communicate that there is a possible breaking change for GitHub Enterprise Server 3.3 and earlier.

it was recommended previously by Github to bump major version, thus changed package version to 3.0.0. Let me know if this needs to be changed

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 30, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is looking good thanks for your contribution!

Only one small thing to address and then I can merge this and also update the github-actions-core library

package.json Outdated Show resolved Hide resolved
@ahanoff
Copy link
Contributor Author

ahanoff commented Feb 6, 2024

hi @JenGoldstrich, I've reverted package version

Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Planning to release this in later this week, thanks again!

@JenGoldstrich JenGoldstrich merged commit 6669b85 into hashicorp:main Feb 7, 2024
1 check passed
jooola pushed a commit to hetznercloud/packer-plugin-hcloud that referenced this pull request Feb 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [hashicorp/setup-packer](https://togithub.com/hashicorp/setup-packer)
| action | major | `v2.0.1` -> `v3.0.0` |

---

### Release Notes

<details>
<summary>hashicorp/setup-packer (hashicorp/setup-packer)</summary>

###
[`v3.0.0`](https://togithub.com/hashicorp/setup-packer/releases/tag/v3.0.0)

[Compare
Source](https://togithub.com/hashicorp/setup-packer/compare/v2.0.1...v3.0.0)

#### What's Changed

GitHub has previously recommended updating the major version of the
action when bumping the node version due to the possibility of breaking
changes with GitHub Enterprise versions potentially not having access to
the newest node versions yet, because of this we have bumped the release
major version to `v3.0.0` for the release of this action using node 20

- feat: update action runner to use NodeJS 20 by
[@&#8203;ahanoff](https://togithub.com/ahanoff) in
[hashicorp/setup-packer#90
- Use GHA Core 0.4.1 and prepare setup-packer 3.0.0 by
[@&#8203;JenGoldstrich](https://togithub.com/JenGoldstrich) in
[hashicorp/setup-packer#92

#### New Contributors

- [@&#8203;ahanoff](https://togithub.com/ahanoff) made their first
contribution in
[hashicorp/setup-packer#90

**Full Changelog**:
hashicorp/setup-packer@v2.0.1...v3.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/hetznercloud/packer-plugin-hcloud).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeJS 16 deprecation on Github Actions
3 participants