Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ink v3 #559

Merged
merged 24 commits into from
Mar 5, 2021
Merged

Upgrade to ink v3 #559

merged 24 commits into from
Mar 5, 2021

Conversation

skorfmann
Copy link
Contributor

This PR upgrades to ink v3. This required a small amount of changes around removed <Color> elements. See more details about what changed in v3 here.

A few neat things which are made possible by the upgrade:

React Devtools

export DEV=true
cdktf diff

And in another terminal

npx react-devtools

Will give you
Screenshot 2021-02-11 at 11 02 12

Terminal Dimensions

With the capability to measure elements and subscribe to terminal dimensions, we are now in a position to handle scrollback issues

Better console output

Doing something like console.log('foo') won't be overwritten anymore by the react rendering output

Error Boundary

A way nicer way of default handling of errors - see vadimdemedes/ink#303

References

fixes: #166

@skorfmann skorfmann marked this pull request as draft February 11, 2021 16:21
@skorfmann skorfmann marked this pull request as ready for review February 22, 2021 19:23
Copy link
Collaborator

@jsteinich jsteinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably the least familiar with the UI side of the project, but looks like a fairly straight-forward change.

packages/cdktf-cli/test/ui/destroy.test.tsx Outdated Show resolved Hide resolved
@skorfmann
Copy link
Contributor Author

I'm probably the least familiar with the UI side of the project, but looks like a fairly straight-forward change.

Yes, overall it's rather straightforward. Primarily changes around Color and Text components, plus a bit of layout fixes here and there. That's what trigger the refactoring of the integration tests :)

@skorfmann skorfmann requested a review from jsteinich March 4, 2021 15:44
@skorfmann skorfmann merged commit e721ec6 into main Mar 5, 2021
@skorfmann skorfmann deleted the upgrade-ink branch March 5, 2021 13:53
@skorfmann skorfmann mentioned this pull request Mar 11, 2021
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Ink v3
2 participants