Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csharp examples readme.md is python instructions #745

Closed
annerajb opened this issue May 28, 2021 · 4 comments
Closed

Csharp examples readme.md is python instructions #745

annerajb opened this issue May 28, 2021 · 4 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation priority/important-soon High priority, to be worked on as part of our current release or the following one.
Milestone
0.5

Comments

@annerajb
Copy link

annerajb commented May 28, 2021 •
edited

https://github.com/hashicorp/terraform-cdk/blob/main/examples/csharp/azure/README.md

Is just python stuff not a single csharp or dotnet command in sight..
@annerajb annerajb added bug Something isn't working new Un-triaged issue labels May 28, 2021
@jsteinich
Copy link
Collaborator

Ref #551

We may just remove it in favor of the getting started guide. If it were to stick around, what would you like to see in it?

@annerajb
Copy link
Author

That sounds like a good idea that document is more complete.

@jsteinich jsteinich mentioned this issue May 30, 2021
Open
@jsteinich
Copy link
Collaborator

@skorfmann are you good with just removing the readme (at least temporarily)? We could come up with a standard readme for default examples if wanted to as well.

danieldreier pushed a commit that referenced this issue Jul 2, 2021
fix(docs) remove Csharp readme in Python for #745
15ebad6 
Remove the C# Azure example readme that only shows Python code.
Resolves #745
@danieldreier danieldreier mentioned this issue Jul 2, 2021
Merged
@danieldreier danieldreier added documentation Improvements or additions to documentation priority/important-soon High priority, to be worked on as part of our current release or the following one. labels Jul 2, 2021
@danieldreier danieldreier added this to the 0.5 milestone Jul 2, 2021
@danieldreier danieldreier self-assigned this Jul 2, 2021
@danieldreier danieldreier removed the new Un-triaged issue label Jul 2, 2021
DanielMSchmidt added a commit that referenced this issue Jul 7, 2021
@DanielMSchmidt
Merge pull request #820 from hashicorp/danieldreier/fix-745
f587656 
fix(docs): remove Csharp readme in Python for #745
@ansgarm ansgarm mentioned this issue Jul 29, 2021
Merged
@danieldreier danieldreier removed their assignment Oct 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation priority/important-soon High priority, to be worked on as part of our current release or the following one.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
3 participants
@annerajb @jsteinich @danieldreier