Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): use jest asymetric matchers & nicer error messages #1052

Merged
merged 1 commit into from
Sep 21, 2021
Merged

feat(lib): use jest asymetric matchers & nicer error messages #1052

merged 1 commit into from
Sep 21, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Sep 20, 2021 •
edited

  • Allows Jest users to write assertions using asymetric matchers (e.g. expect.arrayContaining or expect.stringContaining) making the assertions easier to write
  • Adds more context to a failed test by showing the resources found of the given type
  • Changes the semantic of toHaveResourceWithProperties and toHaveDataSourceWithProperties from object equality to deep equality

Closes #1047

@DanielMSchmidt DanielMSchmidt force-pushed the fix-testing-assertions-deep-equal branch 3 times, most recently from dec7346 to 5a7fdb3 Compare September 20, 2021 16:59
ansgarm
ansgarm approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to using this 🚀 Only some minor non-blocking this from me 👀

@DanielMSchmidt
Copy link
Contributor Author

Tested this in a built version ✅

@DanielMSchmidt DanielMSchmidt force-pushed the fix-testing-assertions-deep-equal branch 2 times, most recently from 6a6dfe3 to bc78afa Compare September 21, 2021 09:03
@ansgarm ansgarm mentioned this pull request Sep 21, 2021
Closed
@ansgarm
Copy link
Member

ansgarm commented Sep 21, 2021

Love the new name 😄

@DanielMSchmidt DanielMSchmidt merged commit 0c7464e into main Sep 21, 2021
@DanielMSchmidt DanielMSchmidt deleted the fix-testing-assertions-deep-equal branch September 21, 2021 09:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use deep equality check in toHaveResourceWithProperties / toDataSourceWithProperties
2 participants
@DanielMSchmidt @ansgarm