Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add telemetry docs #1071

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

danieldreier
Copy link
Contributor

resolves #970

This is largely copied from https://github.com/hashicorp/terraform-cdk/blob/main/docs/working-with-cdk-for-terraform/telemetry.md so once this is published we should probably update that to link to the website version.

@danieldreier danieldreier added documentation Improvements or additions to documentation feature/telemetry labels Sep 23, 2021
@danieldreier danieldreier linked an issue Sep 23, 2021 that may be closed by this pull request
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left a couple of suggestions.

website/docs/cdktf/telemetry.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/telemetry.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/telemetry.html.md Outdated Show resolved Hide resolved
danieldreier and others added 3 commits September 23, 2021 14:26
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
Copy link
Contributor

@schersh schersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@danieldreier danieldreier merged commit 2f8ebb2 into terraform-io-docs Sep 27, 2021
@danieldreier danieldreier deleted the danieldreier-docs-telemetry branch September 27, 2021 17:46
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation feature/telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs page] Telemetry
3 participants