Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Combine Resources and Providers pages #1092

Merged
merged 9 commits into from
Oct 4, 2021

Conversation

laurapacilio
Copy link
Contributor

This PR:

  • Combines the Resources and Provider pages, based on a suggestion from @danieldreier . They are incredibly related, so even though they aren't set up this way in the Terraform documentation, this combination feels right
  • Written contextual information to help users understand what providers and resources are and how they use them in their applications.
  • Reordered original content from docs to help with flow
  • Done an initial rough copyedit
  • Added some TODOs for Engineering.

Copy link
Contributor

@schersh schersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave the technical review for engineering, but just added a few suggested copy edits. Thanks!

@schersh schersh changed the title Combine Resources and Providers pages chore(docs): Combine Resources and Providers pages Sep 28, 2021
laurapacilio and others added 4 commits September 29, 2021 14:58
Co-authored-by: Sarah Hersh <schersh@users.noreply.github.com>
Co-authored-by: Sarah Hersh <schersh@users.noreply.github.com>
Co-authored-by: Sarah Hersh <schersh@users.noreply.github.com>
Co-authored-by: Sarah Hersh <schersh@users.noreply.github.com>
@laurapacilio
Copy link
Contributor Author

awesome! @danieldreier and/or @skorfmann let us know what you think! And if you have input for the TODOs please put it in comments/suggestions and I can add it in!

@laurapacilio laurapacilio merged commit 7d511f3 into terraform-io-docs Oct 4, 2021
@laurapacilio laurapacilio deleted the laura-merge-providers-resources branch October 4, 2021 19:01
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants