Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Aws Adapter #1149

Merged
merged 8 commits into from
Oct 18, 2021
Merged

feat(docs): Aws Adapter #1149

merged 8 commits into from
Oct 18, 2021

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Oct 15, 2021 •
edited

Adds docs for the new AWS Adapter (originally #1123, now moved to separate repository cdktf-aws-cdk)

@ansgarm ansgarm changed the base branch from main to terraform-io-docs October 15, 2021 15:08
@ansgarm ansgarm changed the title Docs: Aws Adapter docs: Aws Adapter Oct 15, 2021
Base automatically changed from terraform-io-docs to main October 15, 2021 20:11
@ansgarm ansgarm marked this pull request as ready for review October 15, 2021 20:12
@ansgarm ansgarm changed the title docs: Aws Adapter feat(docs): Aws Adapter Oct 15, 2021
laurapacilio
laurapacilio reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just suggesting some reorganization/rewording. Really excellent work on this so far!!!

website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
laurapacilio
laurapacilio approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! A couple of nits for wording and then I added in some subsections in the usage part that will help break up the example into specific steps that folks need to remember to do when using this. What do you think?

website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/aws-adapter.html.md Outdated Show resolved Hide resolved
@ansgarm @laurapacilio
fix(docs): apply suggestions from code review
dd0b72d 
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
@ansgarm
Copy link
Member Author

ansgarm commented Oct 18, 2021

Thanks @laurapacilio 💯
Added all suggestions as they were ✨

@ansgarm ansgarm merged commit 70ffe5f into main Oct 18, 2021
@ansgarm ansgarm deleted the docs-aws-adapter branch October 18, 2021 19:41
@DanielMSchmidt DanielMSchmidt mentioned this pull request Oct 19, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laurapacilio laurapacilio laurapacilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ansgarm @laurapacilio