Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Proofreading edits #1150

Merged
merged 13 commits into from
Oct 15, 2021
Merged

chore(docs): Proofreading edits #1150

merged 13 commits into from
Oct 15, 2021

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Oct 15, 2021

  • Splitting up a long sentence
  • Consistent punctuation on final list of get started

* Splitting up a long sentence
* Consistent punctuation on final list of get started
@phinze phinze requested a review from schersh October 15, 2021 20:27
@phinze phinze marked this pull request as draft October 15, 2021 20:29
@phinze phinze changed the title chore(docs): Proofreading edits for index page chore(docs): Proofreading edits Oct 15, 2021
HCL is declarative, these fancy languages CDK lets you use are imperative!
dnsimple provider needs namespace to work properly
Need to import `Token` in the example to use it
Match braces and remove extraneous const from second example
Tweak opening sentence so it's slightly less confusing about its plurals
Remove extra word
Need `RemoteBackend` in imports
Copy link
Contributor

@schersh schersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great edits, thank you!

@schersh schersh marked this pull request as ready for review October 15, 2021 22:40
@schersh schersh merged commit a0d8f72 into main Oct 15, 2021
@schersh schersh deleted the docs-index-edits branch October 15, 2021 22:42
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants