Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider-generator): rename lambda namespace in lambda functions #1154

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

In python this lead a problem with importing this aws resource

Closes #1152

@DanielMSchmidt DanielMSchmidt force-pushed the rename-lambda-functions-for-use-in-python branch from 77f3871 to cc5c9a4 Compare October 18, 2021 09:55
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is fine with me as all resources belonging to the AWS Lambda Service are geared around Lambda Functions.

@skorfmann fine with you as well?

@DanielMSchmidt DanielMSchmidt force-pushed the rename-lambda-functions-for-use-in-python branch 2 times, most recently from f08c856 to a23a447 Compare October 18, 2021 10:55
In python this lead a problem with importing this aws resource

Closes #1152
@DanielMSchmidt DanielMSchmidt force-pushed the rename-lambda-functions-for-use-in-python branch from a23a447 to 1a7cacf Compare October 18, 2021 12:14
@skorfmann
Copy link
Contributor

Naming is fine with me as all resources belonging to the AWS Lambda Service are geared around Lambda Functions.

Hm, the naming is a bit confusing.

Just rename for python using feat: allow per-submodule naming configuration aws/jsii#1690

Have you looked into the 2nd option mentioned by @jsteinich?

@DanielMSchmidt
Copy link
Contributor Author

Hm, the naming is a bit confusing.

I'm open for suggestions :)

Have you looked into the 2nd option mentioned by @jsteinich?

I just took a look in rename-lambda-functions-for-use-in-python-only, I'm unsure how to get this working 🤔

Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought a bit about it, and LambdaFunction seems to be the best way right now. Per language renaming would lead to confusion in documentation and similar places. Also, haven't found a better name.

@DanielMSchmidt DanielMSchmidt merged commit 3696a51 into main Oct 18, 2021
@DanielMSchmidt DanielMSchmidt deleted the rename-lambda-functions-for-use-in-python branch October 18, 2021 13:20
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python cdktf imports throwing error
3 participants