Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider-generator): Mutating complex objects #1331

Merged
merged 5 commits into from
Nov 23, 2021

Conversation

jsteinich
Copy link
Collaborator

Fixes #1246

@jsteinich
Copy link
Collaborator Author

The watch integration test seemed to hang for several hours. I just cancelled it.

Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's super awesome, thanks a ton 👍 🎉 I had tried to build something similar, but failed since I did not properly abstract internal / external value, great work 🎉

@DanielMSchmidt DanielMSchmidt merged commit 2636181 into hashicorp:main Nov 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutating Complex Objects does not work
2 participants