New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): number[] Tokens #1471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I read over it, but can we make sure we throw and error when a list number token is found outside a list? I'm not sure if we have a check for it with strings, but having more than one item in a tokenized list is also a potential bug isn't it?
Yep, I added that check at the same level as the existing string check: |
bf5785f
to
a8c2b3e
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Dividing up #1299, adding token support for
number[]
.Combines the concepts from
number
andstring[]
tokens by using a single element array using a subset of the available bits as a marker for the token.