Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider-generator): allow tfResourceType to be narrowly typed #1535

Merged
merged 7 commits into from
Mar 21, 2022
Merged

feat(provider-generator): allow tfResourceType to be narrowly typed #1535

merged 7 commits into from
Mar 21, 2022

Conversation

rraziel
Copy link
Contributor

@rraziel rraziel commented Feb 3, 2022

Implements #1523.

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 3, 2022

CLA assistant check
All committers have signed the CLA.

@rraziel rraziel changed the title Compile-time resource/data type name for TypeScript bindings feat(provider-generator): allow tfResourceType to be narrowly typed Feb 3, 2022
@DanielMSchmidt
Copy link
Contributor

Hey, could you run yarn test:update to update the snapshot tests?

@rraziel
Copy link
Contributor Author

rraziel commented Feb 3, 2022

@DanielMSchmidt I'd love to but it seems like most commands/the build/the tests are failing for me 😅

$ yarn test:update
yarn run v1.22.17
$ npx lerna exec --parallel --no-bail --scope 'cdktf*' --scope '@cdktf/*' npx 'jest -u'
ERR! lerna Unknown arguments: u, '

If I execute the npx line myself (which somehow doesn't have that lerna error), the tests run but a number of them fail. And if I execute the failing test directly manually, then it passes...

I have many other issues with test and build (mentioned in #1523), not sure how to solve them... I assume nobody else uses Windows on this project, or I'm just really bad at this? 😅

edit: I guess I'll just do it from Linux 😁

@DanielMSchmidt DanielMSchmidt added the ci/update-snapshots When set on a PR a GH Action will update and push all snapshot tests label Feb 10, 2022
@ansgarm ansgarm removed the ci/update-snapshots When set on a PR a GH Action will update and push all snapshot tests label Feb 15, 2022
@jsteinich jsteinich added the ci/update-snapshots When set on a PR a GH Action will update and push all snapshot tests label Mar 9, 2022
@github-actions github-actions bot added ci/updating-snapshots CI is currently updating this PR with new snapshot tests and removed ci/update-snapshots When set on a PR a GH Action will update and push all snapshot tests ci/updating-snapshots CI is currently updating this PR with new snapshot tests labels Mar 9, 2022
@jsteinich jsteinich added the ci/update-snapshots When set on a PR a GH Action will update and push all snapshot tests label Mar 10, 2022
@github-actions github-actions bot added ci/updating-snapshots CI is currently updating this PR with new snapshot tests and removed ci/update-snapshots When set on a PR a GH Action will update and push all snapshot tests labels Mar 10, 2022
Signed-off-by: github-team-tf-cdk <github-team-tf-cdk@hashicorp.com>
@github-actions github-actions bot removed the ci/updating-snapshots CI is currently updating this PR with new snapshot tests label Mar 11, 2022
Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging based on the discussion in #1523 I think this looks good

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants