-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider-generator): allow tfResourceType to be narrowly typed #1535
feat(provider-generator): allow tfResourceType to be narrowly typed #1535
Conversation
Hey, could you run |
@DanielMSchmidt I'd love to but it seems like most commands/the build/the tests are failing for me 😅 $ yarn test:update
yarn run v1.22.17
$ npx lerna exec --parallel --no-bail --scope 'cdktf*' --scope '@cdktf/*' npx 'jest -u'
ERR! lerna Unknown arguments: u, ' If I execute the npx line myself (which somehow doesn't have that lerna error), the tests run but a number of them fail. And if I execute the failing test directly manually, then it passes... I have many other issues with test and build (mentioned in #1523), not sure how to solve them... I assume nobody else uses Windows on this project, or I'm just really bad at this? 😅 edit: I guess I'll just do it from Linux 😁 |
Signed-off-by: github-team-tf-cdk <github-team-tf-cdk@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging based on the discussion in #1523 I think this looks good
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Implements #1523.