Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hcl2cdk): handle no providers passed and add cdktf import for remote state data sources #1561

Merged
merged 6 commits into from
Feb 15, 2022
Merged

fix(hcl2cdk): handle no providers passed and add cdktf import for remote state data sources #1561

merged 6 commits into from
Feb 15, 2022

Conversation

DanielMSchmidt
Copy link
Contributor

Closes #1548

@DanielMSchmidt DanielMSchmidt force-pushed the fix-convert-for-remote-state-data-source branch from 7a19f35 to 974f5d4 Compare February 11, 2022 15:09
@DanielMSchmidt DanielMSchmidt force-pushed the fix-convert-for-remote-state-data-source branch from a19afc1 to e88108c Compare February 14, 2022 10:52
@DanielMSchmidt DanielMSchmidt added the ci/update-snapshots When set on a PR a GH Action will update and push all snapshot tests label Feb 14, 2022
@github-actions github-actions bot added ci/updating-snapshots CI is currently updating this PR with new snapshot tests and removed ci/update-snapshots When set on a PR a GH Action will update and push all snapshot tests ci/updating-snapshots CI is currently updating this PR with new snapshot tests labels Feb 14, 2022
@DanielMSchmidt DanielMSchmidt force-pushed the fix-convert-for-remote-state-data-source branch from e88108c to fca02f0 Compare February 15, 2022 09:37
@DanielMSchmidt DanielMSchmidt merged commit 2f17ade into main Feb 15, 2022
@DanielMSchmidt DanielMSchmidt deleted the fix-convert-for-remote-state-data-source branch February 15, 2022 13:18
@DanielMSchmidt DanielMSchmidt mentioned this pull request Feb 16, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Converted remote state data sources fail to synth
2 participants
@DanielMSchmidt @ansgarm