Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support Auto Updating Snapshots for forks #1595

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

jsteinich
Copy link
Collaborator

The goal is to support the ci/update-snapshots for PRs originating in forks.
I'm not certain if this will work as is and I'm not sure the best way to test this without merging in.

@ansgarm
Copy link
Member

ansgarm commented Feb 25, 2022

Me neither 😁 I'd be happy with just trying – we can always revert 👍

@ansgarm ansgarm merged commit a22cb82 into hashicorp:main Feb 25, 2022
@ansgarm
Copy link
Member

ansgarm commented Feb 25, 2022

@jsteinich you could try this on a new PR of yours now :)

@jsteinich
Copy link
Collaborator Author

It took almost 2.5 hours, but it seems like it worked.

@ansgarm
Copy link
Member

ansgarm commented Feb 28, 2022

Yeah, they run in sequence because else they could overwrite each other (with git not properly detecting changes)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants