-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): serial multi-stack deploys #1609
feat(cli): serial multi-stack deploys #1609
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hashicorp/terraform-cdk/FvbaiDzwQ5Ma5MYCBBVezBFEw18v [Deployment for c10eeaf canceled] |
6153a9a
to
206b042
Compare
206b042
to
14af2e7
Compare
14af2e7
to
6702f42
Compare
6702f42
to
23d27cb
Compare
23d27cb
to
fa3b679
Compare
fa3b679
to
9e5fd54
Compare
c10eeaf
to
c1bf94e
Compare
c1bf94e
to
9ef91e6
Compare
9b7de8f
to
209e948
Compare
Synth, output, and maybe diff should support multiple stacks. We should aim for parity with the AWS CDK with how multiple stacks are specified (https://docs.aws.amazon.com/cdk/v2/guide/cli.html#cli-stacks) |
Yeah, we are going to do this in separate PRs for synth and output 👍 Not sure how diff should be working, if there is a dependency there might be no way to diff (if the provider requires a previously provisioned endpoint to be there for example). How do you think this should look like?
Yeah agreed, will be done in a later PR :) |
I would expect it to try and diff the stacks using the same dependency ordering as other places. Yes, sometimes the diff would fail, but that's not really any different than how it works in HCL. |
Signed-off-by: github-team-tf-cdk <github-team-tf-cdk@hashicorp.com>
Destroy is not yet supported but can be passed multiple stacks
there is a bit of change in also for creating a new dir per testcase to make them more robust
079555e
to
257d9ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @DanielMSchmidt 🎉
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
The goal of this PR is to make a first step towards multi-stack deployments by running each deployment after another (with no parallelism). This ships a lot of the important infrastructure (running in the correct order, handling aborts, etc) while leaving the management of multiple deployments at the same time open for a follow up PR.